[Lldb-commits] [PATCH] D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts

[Luboš Luňák via Phabricator via lldb-commits]

llunak added inline comments.


================
Comment at: lldb/source/Core/IOHandler.cpp:4340-4349
-    case 'k':
-      // 'k' == kill
-      {
-        ExecutionContext exe_ctx =
-            m_debugger.GetCommandInterpreter().GetExecutionContext();
-        if (exe_ctx.HasProcessScope())
-          exe_ctx.GetProcessRef().Destroy(false);
----------------
clayborg wrote:
> Is this not handled in the process menu? 'k' seems dangerous. Either that or we can introduce a confirmation dialog?
I think you got this backwards, it doesn't add a shortcut for kill, it removes it.



Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68908/new/

https://reviews.llvm.org/D68908