[Lldb-commits] [PATCH] D84809: [lldb] Various related target create improvements

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: jingham.
Herald added subscribers: teemperor, abidh.
JDevlieghere requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

- General cleanup in TargetList::CreateTargetInternal.
- Add the missing `--platform` option to target create so you can specify a different platform than the currently selected one.
- Fix the bogus error message that suggests passing a platform with `--platform` when no platforms support the given binary.
- Fix the bogus error message that tells the user to specify the platform with --platform when multiple platforms support the given binary.
- Improve test coverage.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D84809

Files:
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Target/TargetList.cpp
  lldb/test/API/commands/target/basic/TestTargetCommand.py
  lldb/test/API/commands/target/basic/bogus.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84809.281398.patch
Type: text/x-patch
Size: 55222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200728/3638c7f8/attachment-0001.bin>