[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Mon Jul 27 11:59:22 PDT 2020

phosek marked 4 inline comments as done.
phosek added inline comments.

================
Comment at: mlir/examples/standalone/CMakeLists.txt:35
+endif()
+
 include(TableGen)
----------------
stephenneuendorffer wrote:
> mehdi_amini wrote:
> > mehdi_amini wrote:
> > > I am a bit unsure that it is desirable that it is desirable to need this change?
> > > This requires every single user of LLVM to do this. Is there a way this can be done in the call to `find_package(LLVM)` instead?
> > (Doc for the usual way to integrate LLVM: https://llvm.org/docs/CMake.html#embedding-llvm-in-your-project )
> I tend to agree with Mehdi.  I think stuff like this which is *required* to use LLVM should get pushed into what LLVM exports.  (Actually there is a bunch of other configuration stuff which also needs to get pushed into the export, otherwise configuration defaults are all wrong and things like that.)
Implemented in D84691.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219