[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This overall change makes sense to me.

It seems a little awkward that Target has to know that Watchpoints have a m_hit_counter.  It's also a little weird that we're clearing watchpoint hit counts when a process dies, but not breakpoint hit counts.  If we do one we should do the other...  That isn't your doing, but if you need to have Target resetting both the WP & BP hit counts, it might be nicer to do this with an API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84527/new/

https://reviews.llvm.org/D84527