[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

[Frederic Riss via Phabricator via lldb-commits]

friss created this revision.
friss added a reviewer: aprantl.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.

This commit is somewhat NFC-ish today as the environment of triples
is not considered when comparing s if one of them is
not set (I plan to change that).

We have made simulator triples unambiguous these days, but the
simulator platforms still advertise triples without the
environment. This wasn't an issue when the sims ran only on
a very different architecure than the real device, but this
has changed with Apple Silicon.

This patch simplifies the way GetSupportedArchitectureAtIndex
is implemented for the sim platforms and adds the environment.
It also trivially adds support for Apple Silicon to those
platforms.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84537

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
  lldb/unittests/Platform/CMakeLists.txt
  lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84537.280496.patch
Type: text/x-patch
Size: 14779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200724/80a022ea/attachment-0001.bin>