[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

Tatyana Krasnukha via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 24 06:52:22 PDT 2020


tatyana-krasnukha updated this revision to Diff 280448.
tatyana-krasnukha added a comment.

@omjavaid, thank you for verifying this!

Added the checks that IsHardware is consistent with m_hardware_index.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84257/new/

https://reviews.llvm.org/D84257

Files:
  lldb/include/lldb/Breakpoint/BreakpointLocation.h
  lldb/include/lldb/Breakpoint/BreakpointSite.h
  lldb/include/lldb/Breakpoint/StoppointLocation.h
  lldb/source/Breakpoint/BreakpointLocation.cpp
  lldb/source/Breakpoint/Watchpoint.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84257.280448.patch
Type: text/x-patch
Size: 7687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200724/210266f8/attachment-0001.bin>


More information about the lldb-commits mailing list