[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha created this revision.
Herald added subscribers: lldb-commits, yaxunl, mgorny.
Herald added a project: LLDB.

Working on the patch  D84257 <https://reviews.llvm.org/D84257> I noticed that both BreakpointLocation and BreakpointSite were inherited from StoppointLocation. Also, I noticed that they have not so much in common, except the //id// and hit counting logic.
There is no polymorphic code that uses a pointer/reference to StoppointLocation to handle one of BreakpointLocation and BreakpointSite either.

The patch renames  StoppointLocation to StoppointSite and stops BreakpointLocation's inheriting from it.
Hit counting is encapsulated into StoppointHitCounter which is re-used it in StoppointSite, BreakpointLocation, and Breakpoint.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84527

Files:
  lldb/include/lldb/Breakpoint/Breakpoint.h
  lldb/include/lldb/Breakpoint/BreakpointLocation.h
  lldb/include/lldb/Breakpoint/BreakpointSite.h
  lldb/include/lldb/Breakpoint/StoppointHitCounter.h
  lldb/include/lldb/Breakpoint/StoppointLocation.h
  lldb/include/lldb/Breakpoint/StoppointSite.h
  lldb/include/lldb/Breakpoint/Watchpoint.h
  lldb/source/Breakpoint/Breakpoint.cpp
  lldb/source/Breakpoint/BreakpointLocation.cpp
  lldb/source/Breakpoint/BreakpointSite.cpp
  lldb/source/Breakpoint/CMakeLists.txt
  lldb/source/Breakpoint/StoppointLocation.cpp
  lldb/source/Breakpoint/StoppointSite.cpp
  lldb/source/Breakpoint/Watchpoint.cpp
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84527.280422.patch
Type: text/x-patch
Size: 27254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200724/95d4b66f/attachment-0001.bin>