[Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

[Adrian Prantl via lldb-commits]

Is there some clever C++ way to prohibit taking an object's address (similar to how you can delete a copy constructor)?

-- adrian

> On Jul 23, 2020, at 12:20 AM, Pavel Labath <pavel at labath.sk> wrote:
> 
> On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote:
>> -  ConstString operator=(ConstString rhs) {
>> +  ConstString operator=(const ConstString &rhs) {
> 
> ConstString is trivially copyable (well, it has a user defined copy
> constructor but it is trivial...).
> 
> Plus, not so long ago (D59030) we changed all `const ConstString &`s to
> plain `ConstString`. It would be good to avoid flipping this back and
> forth all the time.