[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: JDevlieghere, MaskRay, clayborg.
Herald added a subscriber: aprantl.
Herald added a project: LLDB.

The intention here is to prune out line sequences addresses referring
outside any known sections. Such line sequences are typically produced
by dead-stripped code, which leaves behind some debug info.

These line sequences were pretty much ignored already -- they would fail
at the LineTable::ConvertEntryAtIndexToLineEntry stage. However, they
still made it into the line table and into the "image dump line-table"
output, which was printing random nonsense  as a result.

This avoids putting these sequences into the line table in the first
place, which makes them smaller (some files have a lot of dead line
sequences) and hopefully slightly speeds up code which iterates through
the line table linearly.

It also makes the "image dump line-table" output sane, which means I can
write my test for handling of different linker tombstoning behaviors.

Depends on D84401 <https://reviews.llvm.org/D84401>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84402

Files:
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/test/Shell/SymbolFile/DWARF/debug_line-tombstone.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84402.280097.patch
Type: text/x-patch
Size: 5237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200723/9196a14c/attachment.bin>