[Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 23 00:20:51 PDT 2020


On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote:
> -  ConstString operator=(ConstString rhs) {
> +  ConstString operator=(const ConstString &rhs) {

ConstString is trivially copyable (well, it has a user defined copy
constructor but it is trivial...).

Plus, not so long ago (D59030) we changed all `const ConstString &`s to
plain `ConstString`. It would be good to avoid flipping this back and
forth all the time.


More information about the lldb-commits mailing list