[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The current lldb behavior is that when you start up lldb, it reads the editline command-history file (so the history of the previous session), and loads it into it's internal command history, which you can get to by up and down arrows or ^R searches.  But it doesn't prime the list that the "command history" command has access to.  So command history starts out empty.  But IMO, that's just bug.  If a command shows up in scrolling through with up-arrow, it should also be listed in the history command wherever it lives.  This really reduces the utility of the "history" command...  I think we do want to show this.  We might want mark in the "command history" output where the imported commands end and the new commands start, but we really should make them available.

However, even if we started doing this right, I think the list of historical commands that were imported into lldb at startup properly belong to the current session.  So I don't think this really argues either way.

I'm fine with history going under session.

I didn't hit "accept revision" because I only addressed Raphael's question, I haven't read the patch yet.  But if somebody else has and is okay with the details, I have no objections to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84307/new/

https://reviews.llvm.org/D84307