[Lldb-commits] [PATCH] D84008: [DWARFYAML] Refactor emitDebugInfo() to make the length be inferred.

Wed Jul 22 05:41:21 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:743
+# RUN: llvm-readelf --hex-dump=.debug_info %t13.o | \
+# RUN:   FileCheck %s --check-prefix=LENGTH
+
----------------
Should this be INFER-LENGTH? (The test is currently failing...)

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:748-750
+##                                       ^-------                   4-byte (accumulated length 0x04)
+##                                                ^-------          4-byte (accumulated length 0x08)
+##                                                         ^------- 4-byte (accumulated length 0x0c)
----------------
I don't think these comments are particularly helpful, since they can be inferred from the byte-count/offset at the start of the line. I think if you want comments, you should say what the bytes represent, like you do elsewhere.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84008/new/

https://reviews.llvm.org/D84008