[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha updated this revision to Diff 279777.
tatyana-krasnukha added a comment.

`BreakpointSite::IntersectsRange` returns `false` for hardware breakpoints, that's why the assertion fails.

Since my bare-metal target loads process's memory via Process::WriteMemory, I have 200+ unresolved tests without this change.

The added test should reproduce the issue for other targets too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84254/new/

https://reviews.llvm.org/D84254

Files:
  lldb/source/Breakpoint/BreakpointSite.cpp
  lldb/source/Target/Process.cpp
  lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/Makefile
  lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py
  lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84254.279777.patch
Type: text/x-patch
Size: 6204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200722/d68acec7/attachment.bin>