[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 22 04:23:15 PDT 2020


mib created this revision.
mib added reviewers: labath, teemperor.
mib added a project: LLDB.
Herald added a subscriber: lldb-commits.

This patch moves the `history` subcommand from the `command` to `session`.
I think it makes more sense to have it there because as the `command` usage
suggests, it should be used to manage custom LLDB command.

However, `history` is essential tied to a debugging session and holds
all commands (not specifically custom ones).

This is also makes it more discoverable as it adds an alias for it.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84307

Files:
  lldb/source/Commands/CommandObjectCommands.cpp
  lldb/source/Commands/CommandObjectSession.cpp
  lldb/source/Interpreter/CommandInterpreter.cpp
  lldb/test/API/commands/command/history/TestCommandHistory.py
  lldb/test/API/commands/session/history/TestSessionHistory.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84307.279764.patch
Type: text/x-patch
Size: 18255 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200722/9664940d/attachment-0001.bin>


More information about the lldb-commits mailing list