[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The `!text` test is correct, since you intend to pass `*text` in as a `ValueObject &`.  But I wouldn't add the GetValueAsUnsigned check, that seems confusing.  The NSStringSummaryProvider is returning a bool to tell you whether it succeeded or not, so it seems odd to pre-judge one of it's error states.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84272/new/

https://reviews.llvm.org/D84272