[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added inline comments.


================
Comment at: lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp:461
   if (type_flags & eTypeIsInteger) {
-    const size_t byte_size = compiler_type.GetByteSize(nullptr).getValueOr(0);
+    const size_t byte_size = compiler_type.GetByteSize(thread).getValueOr(0);
     auto raw_value = ReadRawValue(reg_ctx, byte_size);
----------------
shafik wrote:
> Above you use `&thread` in `return_compiler_type.GetByteSize(&thread)` ... why do both of these work? 
This doesn't compile (but ARC isn't a default target, so probably no one compiled that code).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84267/new/

https://reviews.llvm.org/D84267