[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

Tue Jul 21 08:09:10 PDT 2020

friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

In D83552#2162782 <https://reviews.llvm.org/D83552#2162782>, @labath wrote:

> In D83552#2162555 <https://reviews.llvm.org/D83552#2162555>, @friss wrote:
>
> > The `lldbtest.py` part LGTM, but I'm failing to see how this interacts with `TestWeakSymbols.py`? IIRC, `registerSharedLibraryWithTarget` is an API we call explicitly in the tests, but I don't see it called here.
>
>
> It gets called from `run_to_source_breakpoint`, keying off of the `extra_images` argument.

Which I added... Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83552/new/

https://reviews.llvm.org/D83552