[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

[Benson Li via Phabricator via lldb-commits]

bbli added a comment.

> Setting this no longer makes sense, as it will always be empty. Please remove that. Maybe also rename stdout_content to indicate it also contains stderr. Just plain "output" might suffice?

Ok, deleted it and changed "stdout_content" to "combined_content".

> this error result also doesn't make sense. It looks like you'll also need to update the usage in `getCompilerVersion`

Ohh your right. I should have check whether other functions depended on stderr stream. So checking the rest of the codebase, it seems the output of `system` is also used in `TestDataFormatterSkipSummary.py`, but b/c it only triggers on Macs, I didn't see a failure when I made the change. I have now modified both files accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83425/new/

https://reviews.llvm.org/D83425