[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I think this is as good as we can get right now. Thanks for sticking through. Two quick comments inline.



================
Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:152-153
+
+      if (sve_reg_num != LLDB_INVALID_REGNUM &&
+          offset != LLDB_INVALID_INDEX32) {
+        assert(offset < m_sveregset.GetByteSize());
----------------
Are there any FPR registers which we should not be able to retrieve from the SVE state? I'm wondering if this should be turned into an assert.


================
Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:167-169
+    uint64_t byte_size = 1;
+    uint8_t zeros = 0;
+    const uint8_t *src = &zeros;
----------------
It looks like this is only used in the `IsSVEZ(reg)` block below. You could move the declarations there and avoid initializations with bogus values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77047/new/

https://reviews.llvm.org/D77047