[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

The rewrite of the ObjectFileMachO parts is very nice.  LGTM.



================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:462
+
+typedef unsigned char uuid_t[16];
+struct dyld_shared_cache_dylib_text_info {
----------------
not important but #include "Utility/UuidCompatibility.h" would get you this.


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:2347
             // process the nlist records.
-            if ((m_header.flags & MH_DYLIB_IN_CACHE) == 0) {
+            if (is_shared_cache_image == 0) {
               DataBufferSP strtab_data_sp(
----------------
this is a bool, maybe !is_shared_cache_image would be clearer?  The original code was comparing a bitfield to 0 so it made a little more sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83023/new/

https://reviews.llvm.org/D83023