[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 15 08:44:55 PDT 2020
labath added a comment.
In D83815#2153438 <https://reviews.llvm.org/D83815#2153438>, @JDevlieghere wrote:
> In D83815#2152688 <https://reviews.llvm.org/D83815#2152688>, @labath wrote:
>
> >
>
>
> Given that we were already creating a process group on fork, I'll keep the change on line 902 that kills the process group instead of just the pid.
That seems ok -- all of those arguments (except maybe the last one) don't really apply there. Though I am tempted to remove the setpgid call from the forking method too (or even deleting the entire forking method). :P
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83815/new/
https://reviews.llvm.org/D83815
More information about the lldb-commits
mailing list