[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.

I think your comment got broken by Phabricator. I actually think the old code was fine. It's a generic bug that also applies to `Decltype` (which is already implemented), so someone just has to fix the whole function in a follow up patch (your current code just fixes the TemplateSpecializationType but not Decltype). I can do that, but finding a good testing strategy for this is a bit of a pain (it's a lot of boilerplate to make a dependent type by hand and not sure if we have a good way to reach this from a normal LLDB API).

Just revert the RemoveWrappingTypes to the old implementation and then this is ready to go IMHO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83858/new/

https://reviews.llvm.org/D83858