[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 14 10:29:23 PDT 2020
JDevlieghere added a comment.
In D83787#2150926 <https://reviews.llvm.org/D83787#2150926>, @labath wrote:
> I suppose this might have been because someone wanted to ensure cleanupSubprocesses is not called twice (if multiple subprocesses are spawned). It looks like it should be safe to do so, though it's not completely ideal. TBH, I'm not sure why this needs to be a tear down "hook". I t seems like this could just be a separate step in the normal `tearDown` function...
Makes sense, I'll move it in the regular teardown.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83787/new/
https://reviews.llvm.org/D83787
More information about the lldb-commits
mailing list