[Lldb-commits] [PATCH] D83728: [lldb] Make `process connect` behave correctly in synchronous mode.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, jingham.
Herald added a subscriber: abidh.

In synchronous mode, the `process connect` command and its aliases should wait for the stop event before claiming the command is complete. Currently, the stop event is always handled asynchronously by the debugger. The implementation takes the same approach as `Process::ResumeSynchronous` which hijacks the event and handles it on the current thread. Similarly, after this patch, the stop event is part of the command return object, which is the property used by the test case.

Most of the discussion for this patch took place in D83446 <https://reviews.llvm.org/D83446>


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D83728

Files:
  lldb/include/lldb/Target/Platform.h
  lldb/source/Commands/CommandObjectProcess.cpp
  lldb/source/Target/Platform.cpp
  lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83728.277599.patch
Type: text/x-patch
Size: 8801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200713/5707a026/attachment-0001.bin>