[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D81697#2129407 <https://reviews.llvm.org/D81697#2129407>, @bbli wrote:

> > For example, the thing that's annoying me now is that whenever a test fails in the "make" phase (e.g. a compile error), we only get an error message with the return status, and the original make invocation.
>
> Sure thing, how should I get started(in particular where in the codebase should I look for the compile aspect of this fix)?


I believe the relevant code should be somewhere in `packages/Python/lldbsuite/test/plugins/`. The way I'd approach this is to deliberately introduce a compile error into a test and then work my way back to where is that printed. E.g. if I currently add `CFLAGS_EXTRAS := -std=c99 -foo` to `test/API/sample_test/Makefile` I get the following error:

  Error when building test subject.
  
  Build Command:
  make VPATH=.../lldb/test/API/sample_test -C .../lldb-test-build.noindex/sample_test/TestSampleInlineTest.test_dwarf .... 
  
  Build Command Output:
  clang-10: error: unknown argument: '-foo'
  clang-10: error: unknown argument: '-foo'
  make: *** [<builtin>: main.o] Error 1

Ideally this error should include the actual command line that caused clang to print this error message, as normally the problem will not be as obvious.

> 
> 
>> I'd also be happy to help you with attempting to migrate to a newer unittest framework, if you're willing to give that a shot.
> 
> Hmm, how about I give it a shot after working on the above, so I get more background/learn more about the inner workings of unittest2 first.

Well.. I think this will be a relatively simple fix, so I'm afraid you won't gain any deep unittest knowledge from doing that. But let's see how that goes... We have lots of areas that need improvement, so we can come up with additional warm-up projects :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81697/new/

https://reviews.llvm.org/D81697