[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

[Xing GUO via Phabricator via lldb-commits]

Higuoxing marked 3 inline comments as done.
Higuoxing added a comment.

Newly added tests are marked by inline comments since too many tests are updated 😂.



================
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:685
+
+## c) Test that yaml2obj emits correct DWARF sections when 2 compilation units
+## reference the same abbrev table and then obj2yaml is able to convert them back.
----------------
Added test.


================
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:798
+
+## d) Test that yaml2obj emits correct DWARF sections when one compilation unit
+## with lower offet references an abbrev table with higher offset and another one
----------------
Added test.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:651
 
 ## i) Test that yaml2obj reports an error when 'debug_info' has values in its
+## compilation unit entries but 'debug_abbrev' doesn't have the associated abbrev
----------------
Added test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83116/new/

https://reviews.llvm.org/D83116