[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

[Yifan Shen via Phabricator via lldb-commits]

aelitashen created this revision.
aelitashen added reviewers: wallace, clayborg.
Herald added subscribers: lldb-commits, aprantl.
Herald added a project: LLDB.
aelitashen retitled this revision from "Add Compile Unit List to Modules View" to "[lldb-vscode] Add Compile Unit List to Modules View".
aelitashen updated this revision to Diff 275192.
aelitashen added a comment.

Remove comment line in request_getCompileUnits


User can expand and check compile unit list for the modules that have debug info.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83072

Files:
  lldb/tools/lldb-vscode/lldb-vscode.cpp


Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -1186,10 +1186,7 @@
       int num_units = curr_module.GetNumCompileUnits();
       for (int j = 0; j < num_units; j++) {
         auto curr_unit = curr_module.GetCompileUnitAtIndex(j);
-        // auto unit_file_spec = curr_unit.GetFileSpec();
-        // std::string unit_path = std::string(unit_file_spec.GetDirectory());
         units.emplace_back(CreateCompileUnit(curr_unit));
-        // body.try_emplace(unit_file_spec.GetFilename(), unit_path);
       }
       body.try_emplace("compileUnits", std::move(units));
       break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83072.275192.patch
Type: text/x-patch
Size: 740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200702/0e5fda38/attachment.bin>