[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 1 03:44:30 PDT 2020
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM with some minor nits.
Comment at: lldb/include/lldb/API/SBBreakpoint.h:108
+ SBError AddNameWithErrorHandling(const char *new_name);
I wish we had some documentation when adding a name could fail (e.g. empty name string?) But we can also add this all later as most of this stuff needs documentation.
Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py:146
+ success = bkpt.AddNameWithErrorHandling(bad_name)
+ self.assertTrue(success.Fail(),"We allowed an illegal name: %s"%(bad_name))
bp_name = lldb.SBBreakpointName(self.target, bad_name)
I think we usually put spaces around operators/string literals.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits