[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

Martin Svensson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 30 18:28:14 PDT 2020


poya marked an inline comment as done.
poya added inline comments.


================
Comment at: lldb/source/Expression/REPL.cpp:460
     sub_result.GetMatches(matches);
+    // Prepend command prefix that was excluded in the completion request
+    if (request.GetCursorIndex() == 0) {
----------------
teemperor wrote:
> Nit: Missing `.` at the end of the comment, but I'll fix that when landing.
Thanks, I wasn't sure about the convention since other comments in the same file had it both ways


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82835/new/

https://reviews.llvm.org/D82835





More information about the lldb-commits mailing list