[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/bindings/interface/SBBreakpoint.i:210
+    SBError
+    AddNameWithError (const char *new_name);
+
----------------
In `SBDebugger` we have `InitializeWithErrorHandling`, maybe use the same suffix here for consistency? 


================
Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py:103
+        success = bkpt.AddNameWithError(bkpt_name)
+        self.assertTrue(success.Success(), "We couldn't add a legal name to a breakpoint.")
 
----------------
Seems like a good use case for Pavel's new `assertSuccess` helper? (https://reviews.llvm.org/D82759) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82879/new/

https://reviews.llvm.org/D82879