[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Looks good to me apart from one small detail.

I'll leave it open for others to comment on this, since there are lots of changes.



================
Comment at: lldb/source/Core/ValueObject.cpp:467
   bool ret;
-  ret = scalar_value.ULongLong(1) != 0;
+  ret = scalar_value != 0;
   error.Clear();
----------------
Any reason why this is not inlined in the definition ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82864/new/

https://reviews.llvm.org/D82864