[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 30 08:39:51 PDT 2020
mib added a comment.
Looks good to me apart from one small detail.
I'll leave it open for others to comment on this, since there are lots of changes.
Comment at: lldb/source/Core/ValueObject.cpp:467
- ret = scalar_value.ULongLong(1) != 0;
+ ret = scalar_value != 0;
Any reason why this is not inlined in the definition ?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits