[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

[Davide Italiano via Phabricator via lldb-commits]

davide marked an inline comment as done.
davide added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444
+    size_t bufsize = sizeof(processInfo);
+    if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo,
+               &bufsize, NULL, 0) == 0 && bufsize > 0) {
----------------
echristo wrote:
> JDevlieghere wrote:
> > The `sysctl` call seems like something that would fit into host, we already have a bunch of those in `Host.mm`. Should we create a function there that returns whether a given pid runs under Rosetta?
> Agreed. That seems much cleaner.
https://reviews.llvm.org/D82813


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82491/new/

https://reviews.llvm.org/D82491