[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:1471
+  size_t bufsize = sizeof(processInfo);
+  if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo,
+             &bufsize, NULL, 0) == 0 && bufsize <= 0)
----------------
nit: `static_cast` for consistency with line 1468?


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:1472
+  if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo,
+             &bufsize, NULL, 0) == 0 && bufsize <= 0)
+    return false;
----------------
nit: `nullptr`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82813/new/

https://reviews.llvm.org/D82813