[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added inline comments.


================
Comment at: lldb/source/Core/SearchFilter.cpp:829
+      m_target_sp->GetInlineStrategy() == eInlineBreakpointsHeaders)
+    return flags | eSymbolContextCompUnit;
+  return flags;
----------------
`filter_by_function` now fully overrides `filter_by_cu` and so when you set `eSymbolContextFunction` unconditionally here it makes no sense to set `eSymbolContextCompUnit`.
The real truth is that `eSymbolContextFunction` should be set conditionally according to `GetInlineStrategy()` like `lldb/source/Target/Target.cpp` line 335 does now.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136