[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.

Sorry yes this patch is fine.  To be honest, on x86_64 at least, as you've pointed out, maybe we should just live on eh_frame completely without going through any of these augmentation checks at all.  AFAIK gdb is living off of eh_frame exclusively, it may be that all the compilers have caught on to that and are emitting asynchronous unwind information in eh_frame.

My idea about adding an augmentation letter (most simply, just "is this accurate at every instruction") started to seem more reasonable to me when I learned about how armcc added "armcc+" to its augmentation string to indicate that a bug in their eh_frame generation has been fixed.  (although all the other augmentation string entries I've seen have been single letter ones, so I'm not sure how smart it was to add a whole word there.  It's too bad the augmentation string didn't define a separator.

Thanks for listening to all my eh_frame ramblings on this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82378/new/

https://reviews.llvm.org/D82378