[Lldb-commits] [lldb] d4ef569 - Disable a flaky lldb-vscode test on aarch64

[Pavel Labath via lldb-commits]

These tests are also flaky on GreenDragon:
(http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21850/testReport/,
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21848/testReport/,
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/21847/testReport/).

So, it sounds like this is a general problem and not limited to aarch64
linux (actually, the fact that they are not flaky on x86 may be more
interesting), and so disabling the tests does not seem like the right
solution.

On 24/06/2020 20:09, Walter Erquinigo via lldb-commits wrote:
> 
> Author: Walter Erquinigo
> Date: 2020-06-24T11:09:21-07:00
> New Revision: d4ef569577625d50dfe01ab54c7b9995db3e013f
> 
> URL: https://github.com/llvm/llvm-project/commit/d4ef569577625d50dfe01ab54c7b9995db3e013f
> DIFF: https://github.com/llvm/llvm-project/commit/d4ef569577625d50dfe01ab54c7b9995db3e013f.diff
> 
> LOG: Disable a flaky lldb-vscode test on aarch64
> 
> Summary:
> These tests isflaky only on this arch for some reason. It's testing important features and is not flaky on x86_64, so I'll investigate this arm issue separatedly.
> 
> A flaky run:
> http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5540/steps/test/logs/stdio
> 
> Diff that created those tests:
> https://reviews.llvm.org/D81978
> 
> Added: 
>     
> 
> Modified: 
>     lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
> 
> Removed: 
>     
> 
> 
> ################################################################################
> diff  --git a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
> index c9d99daf9bc6..fb7d71872a16 100644
> --- a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
> +++ b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
> @@ -430,6 +430,8 @@ def test_extra_launch_commands(self):
>  
>      @skipIfWindows
>      @skipIfNetBSD # Hangs on NetBSD as well
> +    @skipIfDarwin
> +    @skipIf(archs="aarch64") # Example of a flaky run http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5540/steps/test/logs/stdio
>      def test_terminate_commands(self):
>          '''
>              Tests that the "terminateCommands", that can be passed during
> 
> 
>         
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>