[Lldb-commits] [PATCH] D82412: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 25 01:35:49 PDT 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:77
+      io_redirect_or_error =
+          options.GetEnableIO()
+              ? ScriptInterpreterIORedirect::Create(m_debugger, result)
----------------
I wonder if we should just pass `options.GetEnableIO()` to the factory function, and let it figure out the details...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82412/new/

https://reviews.llvm.org/D82412





More information about the lldb-commits mailing list