[Lldb-commits] [lldb] 63d5970 - [ObjectFileMachO] Check for TARGET_EMBEDDED instead of listing architectures.

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 23 12:38:28 PDT 2020


Author: Davide Italiano
Date: 2020-06-23T12:37:45-07:00
New Revision: 63d597093cccbb8d4962cf490e2d754a73a77e64

URL: https://github.com/llvm/llvm-project/commit/63d597093cccbb8d4962cf490e2d754a73a77e64
DIFF: https://github.com/llvm/llvm-project/commit/63d597093cccbb8d4962cf490e2d754a73a77e64.diff

LOG: [ObjectFileMachO] Check for TARGET_EMBEDDED instead of listing architectures.

Now that Apple Silicon is a thing, we need to generalize the check.

Added: 
    

Modified: 
    lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index bc4017b86f07..cbcac7b464e6 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -2596,8 +2596,7 @@ size_t ObjectFileMachO::ParseSymtab() {
   typedef std::set<ConstString> IndirectSymbols;
   IndirectSymbols indirect_symbol_names;
 
-#if defined(__APPLE__) &&                                                      \
-    (defined(__arm__) || defined(__arm64__) || defined(__aarch64__))
+#if defined(__APPLE__) && TARGET_OS_EMBEDDED
 
   // Some recent builds of the dyld_shared_cache (hereafter: DSC) have been
   // optimized by moving LOCAL symbols out of the memory mapped portion of


        


More information about the lldb-commits mailing list