[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 23 07:26:17 PDT 2020


teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added subscribers: JDevlieghere, abidh.
teemperor edited the summary of this revision.

This replaces most uses of LLDB's own String to int/float conversion implementation with
LLVM's to_integer. The only remaining code in LLDB that now still uses StringConvert is
debugserver which can't use LLVM code, so I'll leave that part for a future commit.

Unlike the other StringConvert patch this doesn't try to add any missing error handling
but just does a NFC refactoring to `to_integer`.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D82382

Files:
  lldb/source/Host/common/Socket.cpp
  lldb/source/Host/common/XML.cpp
  lldb/source/Interpreter/OptionValueArray.cpp
  lldb/source/Interpreter/OptionValueFileSpecList.cpp
  lldb/source/Interpreter/OptionValuePathMappings.cpp
  lldb/source/Interpreter/OptionValueSInt64.cpp
  lldb/source/Interpreter/OptionValueUInt64.cpp
  lldb/source/Interpreter/Property.cpp
  lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp
  lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  lldb/source/Symbol/SymbolContext.cpp
  lldb/source/Target/UnixSignals.cpp
  lldb/unittests/debugserver/RNBSocketTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82382.272716.patch
Type: text/x-patch
Size: 30666 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200623/855236e5/attachment-0001.bin>


More information about the lldb-commits mailing list