[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk marked 6 inline comments as done.
kwk added inline comments.


================
Comment at: lldb/source/Core/SearchFilter.cpp:713
+  if (!type)
+    return SearchFilterByModuleList::FunctionPasses(function);
+
----------------
jankratochvil wrote:
> If we cannot determine which file the function is from then rather ignore it (the current call returns `true`):
> ```
>   return false;
> ```
@jankratochvil so far I haven't addressed this on purpose to give @labath and @jingham time to say what they think about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136