[Lldb-commits] [PATCH] D81898: [lldb/Python] Fix the infinitely looping prompt bug

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 16 11:00:11 PDT 2020


teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM, but some documentation would be nice.



================
Comment at: lldb/source/Interpreter/embedded_interpreter.py:77
+    line = sys.stdin.readline()
+    if not line:
+        raise EOFError
----------------
`# Empty line from readline indicates EOF`


================
Comment at: lldb/test/Shell/ScriptInterpreter/Python/eof.test:3
+
+CHECK: >>>
+CHECK-NOT: >>>
----------------
I think this should have a comment that ">>>" is the python interpreter prompt and why we check for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81898/new/

https://reviews.llvm.org/D81898





More information about the lldb-commits mailing list