[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: lldb/source/Core/SearchFilter.cpp:732
+    FileSpec cu_spec;
+    if (sym_ctx.comp_unit) {
+      cu_spec = sym_ctx.comp_unit->GetPrimaryFile();
----------------
kwk wrote:
> jankratochvil wrote:
> > This condition is always `true` as there is already above:
> > ```
> > if (!sym_ctx.comp_unit)
> > ```
> > 
> That' incorrect. Only if the nested `if (m_support_file_list.GetSize() != 0)` is `false`, then `sym_ctx.comp_unit` is potentially `true`.
OK, I agree, my comment was a mistake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136