[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 269030.
jankratochvil added a comment.

The new -1 value for `GetAttributes` is a bit ugly. But otherwise either

- `CollectCallEdges` would need to reimplement `GetAttributes`.

or

- trying to guess which attribute belongs to which DIE from `DIEOffsetAtIndex` but that is also not nice because it is offset of the DIE's attribute, not offset of the DIE itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81334/new/

https://reviews.llvm.org/D81334

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_GNU_call_site-DW_AT_low_pc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81334.269030.patch
Type: text/x-patch
Size: 11780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200606/eaf9aece/attachment-0001.bin>