[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 5 11:11:11 PDT 2020

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.


Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:365
+    if (developer_dir.empty())
+      if (FileSpec fspec = HostInfo::GetShlibDir())
+        if (FileSystem::Instance().Exists(fspec)) {
aprantl wrote:
> JDevlieghere wrote:
> > Any reason you choose to leave this inline and not making it a separate function? If we did we could also cache the result like we do for some of the other paths. 
> This function is going to be called at most ~7*2 times, once for each XcodeSDK kind * Internal. So caching isn't really relevant. i also would like to refactor the other function after this patch, which would make factoring this out first really awkward.
Sounds good!



More information about the lldb-commits mailing list