[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 5 10:38:56 PDT 2020
JDevlieghere added inline comments.
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:365
+ if (developer_dir.empty())
+ if (FileSpec fspec = HostInfo::GetShlibDir())
+ if (FileSystem::Instance().Exists(fspec)) {
----------------
Any reason you choose to leave this inline and not making it a separate function? If we did we could also cache the result like we do for some of the other paths.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81210/new/
https://reviews.llvm.org/D81210
More information about the lldb-commits
mailing list