[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 5 10:01:53 PDT 2020


JDevlieghere added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:372
+    if (!developer_dir.empty())
+      xcrun_cmd = "/usr/bin/env DEVELOPER_DIR=" + developer_dir + " ";
+    xcrun_cmd += "xcrun --show-sdk-path --sdk " + sdk_name;
----------------
Not something you should fix for this patch, but `RunShellCommand` should be able to take environment variables. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81210/new/

https://reviews.llvm.org/D81210





More information about the lldb-commits mailing list