[Lldb-commits] [PATCH] D81209: Move GetXcode*Directory into HostInfo (NFC)

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 4 19:19:03 PDT 2020


aprantl created this revision.
aprantl added reviewers: JDevlieghere, friss, jingham.
aprantl added a child revision: D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB.

These functions really don't belong into PlatformDarwin, since they actually query state of the Host and not of the remote platform.


https://reviews.llvm.org/D81209

Files:
  lldb/include/lldb/Host/HostInfoBase.h
  lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
  lldb/include/lldb/Utility/XcodeSDK.h
  lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Utility/XcodeSDK.cpp
  lldb/unittests/Platform/PlatformDarwinTest.cpp
  lldb/unittests/Utility/XcodeSDKTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81209.268636.patch
Type: text/x-patch
Size: 21434 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200605/a66f6242/attachment-0001.bin>


More information about the lldb-commits mailing list