[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

Ilya Bukonkin via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 4 16:37:01 PDT 2020


fallkrum added a comment.

Didn't notice that we use in Process::ProcessEventData::DoOnRemoval:

  this_thread_wants_to_stop = stop_info_sp->ShouldStop(event_ptr);

and yes it is probably correct to fix the issue by this:

  if (stop_info_sp && stop_info_sp->IsValid() && thread_sp->ShouldStop(event_ptr))

But again not sure if all this correct. Because further in the code we call  stop_info_sp->ShouldStop(event_ptr) what looks like a duplicate of  thread_sp->ShouldStop(event_ptr). Need your further comments :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80112/new/

https://reviews.llvm.org/D80112





More information about the lldb-commits mailing list