[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

Thu Jun 4 16:36:56 PDT 2020

jasonmolenda added a comment.

Hi Jan, I noticed our sanitizer bot started getting failures in

Failing Tests (3):

  lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py
  lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63
  lldb-shell :: SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s

/Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/source/Utility/DataExtractor.cpp:934:17: runtime error: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long long'); cast to an unsigned type to negate this value to itself
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/source/Utility/DataExtractor.cpp:934:17 in 
http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake-sanitized/detail/lldb-cmake-sanitized/1509/pipeline

TestUnwindExpression might be unrelated, but it looks like DataExtractorTest.GetSLEB128_bit63 and DW_TAG_variable-DW_AT_const_value.s are hitting this ubsan error after this commit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81119/new/

https://reviews.llvm.org/D81119