[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.
Ilya Bukonkin via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 4 13:51:19 PDT 2020
fallkrum marked an inline comment as done.
fallkrum added inline comments.
Comment at: lldb/source/Target/Thread.cpp:382
+ if (m_stop_info_sp->IsValid() ||
+ (IsStillAtLastBreakpointHit() &&
+ m_resume_state != eStateSuspended) ||
> What is historical need for this check? How is it possible for a breakpoint to stop a thread that was already stopped second time even while stepping in multithreaded programs?
Any thoughts on this? Maybe it is better to get rid of IsStillAtLastBreakpointHit at all? In this case there will be no need to check wether thread was suspended.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits